search

google / cap-library

Common Alerting Protocol Library
Apache License 2.0
81 stars 30 forks source link

Empty <references> tag rejected - provide a better error message? #9

Closed sschiavoni closed 9 years ago

sschiavoni commented 9 years ago

Original issue 10 created by andriy@google.com on 2011-03-28T20:08:06.000Z:

When CAP includes a completely empty <references></references> tag, the validator says:

Invalid <references>: "". Must be a space-separated list of sender,identifier,sent triplets.

The message could be changed to indicate that we don't permit empty data. Suggest something like:

Invalid <references>: "". Must be a non-empty, space-separated list of sender,identifier,sent triplets.

sschiavoni commented 9 years ago

Comment #1 originally posted by shakusa@google.com on 2011-03-28T21:40:27.000Z:

http://codereview.appspot.com/4276081

sschiavoni commented 9 years ago

Comment #2 originally posted by shakusa@google.com on 2011-03-30T00:03:56.000Z:

Fix committed and pushed.