search

google / capirca

Multi-platform ACL generation system
Apache License 2.0
778 stars 209 forks source link

Add support for ttl-except and hop-limit-except to the Juniper platform #325

Open nward opened 2 years ago

nward commented 2 years ago

Add support for the ttl-except and hop-limit-except match conditions to the Juniper platform.

Have added tests, and all passing fine.

Have added docs.

Generates valid config.

I have created hop-limit-except as a single value rather than a range, as Juniper does not (to my knowledge) support a range for this option.

google-cla[bot] commented 2 years ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

nward commented 2 years ago

I'm unable to sign the CLA as my org (SearchLight) because https://cla.developers.google.com/clas doesn't let me switch to another Google account I'm logged in as (I have.. 9 or so), so it does not recognise that I am the owner of the group.

I have attempted to switch accounts on https://developers.google.com and it does not take effect on the CLA URL above.

I have signed the CLA personally, and I am a Director of the org.

¯_(ツ)_/¯