G_test version not up-to-date

google / carfac

Cascade of Asymmetric Resonators with Fast-Acting Compression (CARFAC) cochlear model.

Apache License 2.0

116 stars 43 forks source link

G_test version not up-to-date #9

Closed sedurCode closed 3 years ago

sedurCode commented 3 years ago

~~G_test now uses instantiate_test_case_p instead of instantiate_test_suite_p in binaural_sai_test.cc line 97~~

This might actually be a problem with the version of libgtest-dev available via apt-get for ubuntu, from the instructions from the SConstruct.

sedurCode commented 3 years ago

Also arguably, instead of making a local internal copy of gtest that lives in 'tmp', we should be using the users gtest that we have asked them to install

sedurCode commented 3 years ago

Yeah ok, So if I use gtest built from source, instead of sourced from the apt-get package manager, then using the test-suite syntax is correct. I guess this is because apt-get for Ubuntu 18.04 is only up to gtest 1.7.0 which doesnt have test-suite.