search

google / cargo-raze

Generate Bazel BUILD from Cargo dependencies!
Apache License 2.0
480 stars 104 forks source link

Fix features selection, broken by #478 #524

Closed bsilver8192 closed 1 year ago

bsilver8192 commented 2 years ago

It works properly with no explicit targets set (aka "use all the targets"), and it also works properly with some of the examples that set default-members = [].

I think there's still something wrong, because it dropped features from some Windows-specific crates relative to before https://github.com/google/cargo-raze/pull/478, but I'm not sure what's supposed to happen. At least all the tests in this repository pass on Linux again...

bsilver8192 commented 2 years ago

@sayrer FYI, if you want to take a look.

rdelfin commented 2 years ago

I believe this fixes the issue outlined in #530. Thanks a bunch for working on this and fixing it!

rdelfin commented 2 years ago

@dfreese is there any chance this change could be included in a patch/minor release? If this fixes the issue, it would be a huge unblocker for our repo

PiotrSikora commented 1 year ago

@dfreese @illicitonion @acmcarther could one of you review this and release v0.16.1? cargo-raze v0.16.0 is pretty much broken without this fix (see: https://github.com/google/cargo-raze/pull/478#issuecomment-1200362639), and I verified that this PR fixes the issue for me.

illicitonion commented 1 year ago

@sayrer Please could you give this a look?

dfreese commented 1 year ago

published 0.16.1