search

google / casa-android

A framework to bootstrap the creation of catalog samples apps by removing all the boilerplate and dynamically including all available samples into a single activity.
Apache License 2.0
263 stars 16 forks source link

Add id field for sample #14

Closed workspace closed 1 year ago

workspace commented 1 year ago

In CatalogNavigation, sample.name is used as the route for sample.

I think it would be better

  1. to have a separate field (such as id or slug) for identifying samples rather than using the name field.
  2. to check for duplicates in the processor for those values.
marcelpinto commented 1 year ago

Yes, that probably would be a better way. We have the sourcePath field we could use as ID. That would even follow a "deeplink" style path.

I will take a look