search

google / cctz

CCTZ is a C++ library for translating between absolute and civil times using the rules of a time zone.
Apache License 2.0
596 stars 166 forks source link

Add an option to separate benchmark build from tests #241

Closed sbraz closed 1 year ago

sbraz commented 1 year ago

Hi, Here is a small PR that will help adding this package to Gentoo. In some cases, it is desirable to run tests but no benchmark.

This change is Reviewable

google-cla[bot] commented 1 year ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

sbraz commented 1 year ago

Opened https://github.com/google/oss-fuzz/pull/9811 to address the failing CI

devbww commented 1 year ago

Opened google/oss-fuzz#9811 to address the failing CI

It seems like this may also be a problem for other users who currently use BUILD_TESTING=OFF to skip anything benchmark related. Can we make it so that BUILD_BENCHMARK is a sub-condition of BUILD_TESTING=ON?

sbraz commented 1 year ago

@devbww how about this? I'm not sure the long option description is a good idea but I thought it was worth mentioning.

devbww commented 1 year ago

Seems reasonable. I might only suggest using parentheses. That is, " (has no effect ...)" instead of ", has no effect ...".

I'll rerun the CI builds.

devbww commented 1 year ago

@derekmauro ... any idea what's up with the kokoro builds. They seem to be "Waiting" forever.

And sorry that this is probably the Nth time I've asked for your advice on such things. :-(

derekmauro commented 1 year ago

It seems like it may have just been a communication issue between GitHub and Kokoro. I applied the tag kokoro:force-run and it ran.

I sent you a change for the Linux CI script to use a newer Docker image. Once that it submitted we can re-run this.