Open Alfus opened 1 year ago
The first one seems to be just missing, the second one seems to be a cycle in the dep graph, that is being 'solved' via ABSL_ATTRIBUTE_WEAK:
// ABSL_ATTRIBUTE_WEAK
//
// Tags a function as weak for the purposes of compilation and linking.
// Weak attributes did not work properly in LLVM's Windows backend before
// 9.0.0, so disable them there. See https://bugs.llvm.org/show_bug.cgi?id=37598
// for further information.
// The MinGW compiler doesn't complain about the weak attribute until the link
// step, presumably because Windows doesn't use ELF binaries.
I suspect the problem with the second one is, the xcode linker used on macos does not respect the weak attribute.
When trying to compile against master I am getting the following linker errors:
I don't see a definition for the first one: https://github.com/search?q=repo%3Agoogle%2Fcel-cpp%20MessageTypeFieldCount&type=code
Though the second one seems to be defined here: https://github.com/google/cel-cpp/blob/58397d797f2c98e2450e5b1df3d5b2048f1e7499/extensions/protobuf/struct_value.cc#L74 though without the
ABSL_ATTRIBUTE_WEAK