google / cel-cpp

Fast, portable, non-Turing complete expression evaluation (C++)
https://cel.dev
Apache License 2.0
160 stars 47 forks source link

Fix nullability annotation of `ReferenceCountingMemoryManager::Allocate()`. #748

Closed copybara-service[bot] closed 1 month ago

copybara-service[bot] commented 1 month ago

Fix nullability annotation of ReferenceCountingMemoryManager::Allocate().

The declaration didn't have an annotation; the definition is annotated as returning nonnull, but it contains a return nullptr.

For the time being, I'm fixing this by removing the annotation on the definition (thereby making it consistent with the declaration). Code owners may want to follow up by marking both the definition and declaration as returning nullable if desired.