google / cel-go

Fast, portable, non-Turing complete expression evaluation with gradual typing (Go)
https://cel.dev
Apache License 2.0
2.31k stars 225 forks source link

Improve token representation in AST #932

Closed kortschak closed 7 months ago

kortschak commented 7 months ago

This change includes vendor directory addition of go-cmp. Unfortunately the go-cmp checks require an end-run around test package hermeticity, but I have made this as minimal as possible.

Please take a look.

Pull Requests Guidelines

See CONTRIBUTING.md for more details about when to create a GitHub [Pull Request][1] and when other kinds of contributions or consultation might be more desirable.

When creating a new pull request, please fork the repo and work within a development branch.

Commit Messages

Background on why the change is being made with additional detail on consequences of the changes elsewhere in the code or to the general functionality of the library. Multiple paragraphs may be used, but please keep lines to 72 characters or less.



## Reviews

* Perform a self-review.
* Make sure the Travis CI build passes.
* Assign a reviewer once both the above have been completed.

## Merging

* If a CEL maintaner approves the change, it may be merged by the author if
  they have write access. Otherwise, the change will be merged by a maintainer.
* Multiple commits should be squashed before merging.
* Please append the line `closes #<issue-num>: description` in the merge message,
  if applicable.

[1]:  https://help.github.com/articles/about-pull-requests
TristonianJones commented 7 months ago

/gcbrun

kortschak commented 7 months ago

Fixed vendoring issue.

TristonianJones commented 7 months ago

/gcbrun

TristonianJones commented 7 months ago

/gcbrun