search

google / cel-go

Fast, portable, non-Turing complete expression evaluation with gradual typing (Go)
https://cel.dev
Apache License 2.0
2.19k stars 218 forks source link

Fixed partial variables extended bug and split PartialVarsEnvExtended test into two #955

Closed jduraniglesias closed 3 months ago

jduraniglesias commented 3 months ago

Changed the varsCopy variable to unconditionally copy e.variables. Split the partial variables extended test into TestPartialVarsEnv and TestPartialVarsExtendedEnv which tests, respectively, if internals are initialized and if sub environment is correctly copied.

Fixes an edge case with env.PartialVars on an extended environment if the base was used for type checking already.

google-cla[bot] commented 3 months ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

TristonianJones commented 3 months ago

/gcbrun

TristonianJones commented 3 months ago

/gcbrun