Open siretart opened 2 months ago
My apologies @siretart, I thought I had replied to this thread, but it's possible there are other issues in common/types/int.go
and common/types/overflow.go
. I'm happy to update reference to these constants where they occur. If I read this right it means type converting the constants, e.g. int64(math.MaxInt64)
, does that sound right to you?
Hi, I'm packaging this library for use of other packages in Debian.
I noticed that in Debian, the tests fails to build on 32bit architectures, e.g.:
In all cases, the relevant part of the build log looks like this:
I suspect the issue is here: https://github.com/google/cel-go/blob/b27008a343bcb5805b63816e41954b3100a05be5/common/types/int_test.go#L35-L54
That test code seems to be written with the assumption to run on 64bit architectures only. I'm going to disable this test in Debian for now, but please let me know if you can think of a better way to address this issue.