CEL proto test of 0.0 vs -0.0 does not hold for all proto implementations

google / cel-spec

Common Expression Language -- specification and binary representation

https://cel.dev

Apache License 2.0

2.78k stars 222 forks source link

CEL proto test of 0.0 vs -0.0 does not hold for all proto implementations #198

Closed jsannemo closed 2 years ago

jsannemo commented 3 years ago

The test field_assign_proto3_round_to_zero checks that the float -0.0 is sent back. Distinguishing between this and 0.0 is, as far as I know, not something that the proto serializers of all languages do (for example, see Java: https://github.com/protocolbuffers/protobuf/issues/7062).

TristonianJones commented 2 years ago

Looks like this is a bug in proto that will be fixed in upcoming releases