fix:Remove lint exceptions and fix lint errors

google / certificate-transparency-go

Auditing for TLS certificates (Go code)

https://certificate.transparency.dev

Apache License 2.0

886 stars 231 forks source link

fix:Remove lint exceptions and fix lint errors #1429

Closed silaselisha closed 4 months ago

silaselisha commented 4 months ago

Checklist

[x] I have updated the Contributors list.
[x] I have removed the exception from .golangci.yaml.
[x] I have fixed all errors.

google-cla[bot] commented 4 months ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

silaselisha commented 4 months ago

@roger2hk a polite request for a review on this PR.

roger2hk commented 4 months ago

@roger2hk a polite request for a review on this PR.

It looks like the Go test failed.

Step #3 - "ci-ready": E0414 20:28:20.354182   15911 distributor.go:209] unknown_error (https://ct.googleapis.com/logs/argon2020/, AddPreChain) => log "https://ct.googleapis.com/logs/argon2020/" has no roots
Step #3 - "ci-ready": E0414 20:28:20.354294   15911 distributor.go:328] GetSCTs(): log-group(s) All-logs didn't receive enough SCTs
Step #3 - "ci-ready": 2024/04/14 20:28:20 failed to close f: "close /tmp/1096101463: file already closed"