google / certificate-transparency-go

Auditing for TLS certificates (Go code)
https://certificate.transparency.dev
Apache License 2.0
861 stars 230 forks source link

Refactor issuance chain service #1512

Closed mhutchinson closed 2 weeks ago

mhutchinson commented 1 month ago

Primary goal is to have 2 separate implementations of the different services, instead of having both implementations inside the same class with conditional switching. This is realized by introducing a direct chain service that performs the legacy implementation of storing chains directly inside the extra data in Trillian. The logic for the new feature is now in an indirect chain service that requires the storage and cache that chains are stored in.

phbnf commented 3 weeks ago

I'm OOO from tomorrow and next week, I'll have a look when I'm back.