search

google / certificate-transparency-go

Auditing for TLS certificates (Go code)
https://certificate.transparency.dev
Apache License 2.0
861 stars 230 forks source link

Flaky cloudbuild test due to concurrent `go build ./...` #1529

Open roger2hk opened 6 days ago

roger2hk commented 6 days ago

The cloudbuild test is flaky from time to time because the go build ... was run concurrently after the ci-ready step.

https://github.com/google/certificate-transparency-go/blob/20f4453f15e869ceff68dbb8546c6f811217e6f4/scripts/presubmit.sh#L99

Sample errors

Created tree 1376086433082563736
/workspace/trillian/integration/ct_functions.sh: line 118: ./createtree: Text file busy
Created tree 2866571834323913394
/workspace/trillian/integration/ct_functions.sh: line 118: ./createtree: No such file or directory

The fix requires some refactoring in both the scripts/presubmit.sh and cloudbuild*.yaml. Note that the coverage flag logic is inside the run_build condition.