[RFC] Extract common code in preparation for RFC6962-bis - Githubissues

google / certificate-transparency

Auditing for TLS certificates.

https://certificate.transparency.dev

Apache License 2.0

868 stars 283 forks source link

[RFC] Extract common code in preparation for RFC6962-bis #1325

Closed daviddrysdale closed 8 years ago

daviddrysdale commented 8 years ago

Summary:

create a general TLS encoding/decoding library, analogous to asn1/
copy/move signature code into it
extract common parts of the LogClient into JSONClient (and tweak slightly) to allow re-use
convert existing v1 client code to use the extracted/generalized versions.

Opinions sought on whether I should do less or more commonization:

I could commonize less; for example, I could leave the existing client/ with its own version of DigitallySigned by just omitting commit 5e8bfae (the current change has knock-on compilation failures for anything that uses ct.DigitallySigned, e.g. Trillian).
I could commonize more, and work through all of the v1 client code to replace the hand-rolled TLS-encoding code with use of the tls/ library.

phad commented 8 years ago

Nothing further from me on the log_client side of things.