google / certificate-transparency

Auditing for TLS certificates.
https://certificate.transparency.dev
Apache License 2.0
869 stars 283 forks source link

Fix TypeError: load_pem_public_key() takes exactly 2 arguments (1 given) #1465

Closed unreturned closed 5 years ago

unreturned commented 5 years ago

Fix

./print_log_list.py --log_list=log_list.json --log_list_schema=log_list_schema.json --signature=log_list.sig --signer_key=log_list_pubkey.pem
Traceback (most recent call last):
  File "./print_log_list.py", line 129, in <module>
    app.run(main)
  File "/home/kovalkov/.local/lib/python2.7/site-packages/absl/app.py", line 300, in run
    _run_main(main, args)
  File "/home/kovalkov/.local/lib/python2.7/site-packages/absl/app.py", line 251, in _run_main
    sys.exit(main(argv))
  File "./print_log_list.py", line 102, in main
    if not is_signature_valid(json_data, FLAGS.signature, FLAGS.signer_key):
  File "./print_log_list.py", line 55, in is_signature_valid
    pubkey = serialization.load_pem_public_key(pubkey_pem)
TypeError: load_pem_public_key() takes exactly 2 arguments (1 given)
googlebot commented 5 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

unreturned commented 5 years ago

I signed it!

googlebot commented 5 years ago

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

pphaneuf commented 5 years ago

Could you add yourself to the AUTHORS and CONTRIBUTORS files, please? Otherwise ready to merge! 😃

unreturned commented 5 years ago

Could you add yourself to the AUTHORS and CONTRIBUTORS files, please? Otherwise ready to merge!

Done, please, check it.

unreturned commented 5 years ago

I`m very sorry, i correct myself with style of file and email with CLA. Dear @pphaneuf , gentle ping. Thank you.

pphaneuf commented 5 years ago

Thanks!