google / certificate-transparency

Auditing for TLS certificates.
https://certificate.transparency.dev
Apache License 2.0
867 stars 282 forks source link

CT doesn't currently build on OpenBSD 5.8 #986

Open Martin2112 opened 8 years ago

Martin2112 commented 8 years ago

The first problem I hit seems to be that the system make objects to the "export INSTALL_DIR" near the top of our build.gclient. I don't see an option to tell gclient to use gmake.

Log output:

Host platform is openbsd5 Using make make with 1 jobs Syncing projects: 100% (17/17), done.

____ running 'make -f /home/martin/ct/certificate-transparency/build.gclient _libunwind' in '/home/martin/ct' *\ Parse error in /home/martin/ct: Need an operator in 'INSTALL_DIR' (certificate-transparency/build.gclient:4) Error: Command 'make -f /home/martin/ct/certificate-transparency/build.gclient _libunwind' returned non-zero exit status 1 in /home/martin/ct

AlCutter commented 8 years ago

Ah - I think need an extra entry in the make_os map in DEPS for "openbsd" (or whatever the sys.platform variable shows on OpenBSD.)

We'll likely need to add some entries in the deps_overrides too, if we're lucky (yeah...) then maybe the FreeBSD overrides will work for OpenBSD too.

Martin2112 commented 8 years ago

OK. I'll work on this in the background. I didn't know about those mappings.

Martin

On 21 October 2015 at 11:54, Al Cutter notifications@github.com wrote:

Ah - I think need an extra entry in the make_os map in DEPS for "openbsd" (or whatever the sys.platform variable shows on OpenBSD.)

We'll likely need to add some entries in the deps_overrides too, if we're lucky (yeah...) then maybe the FreeBSD overrides will work for OpenBSD too.

— Reply to this email directly or view it on GitHub https://github.com/google/certificate-transparency/issues/986#issuecomment-149853463 .

Martin2112 commented 8 years ago

Now seeing this when building tcmalloc:

libtool: compile: g++ -DHAVE_CONFIG_H -I. -I./src -I./src -I/home/martin/ct/install/include -DNO_TCMALLOC_SAMPLES -pthread -DNDEBUG -Wall -Wwrite-strings -Woverloaded-virtual -Wno-sign-compare -fno-builtin-malloc -fno-builtin-free -fno-builtin-realloc -fno-builtin-calloc -fno-builtin-cfree -fno-builtin-memalign -fno-builtin-posix_memalign -fno-builtin-valloc -fno-builtin-pvalloc -DNO_FRAME_POINTER -fPIC -MT src/libtcmalloc_minimal_la-tcmalloc.lo -MD -MP -MF src/.deps/libtcmalloc_minimal_la-tcmalloc.Tpo -c src/tcmalloc.cc -o src/libtcmalloc_minimal_la-tcmalloc.o src/mallochook-inl.h: In member function 'T base::internal::HookList::GetSingular() const [with T = void ()(const void_, size_t)]': src/malloc_hook-inl.h:120: instantiated from here src/mallochook-inl.h:87: error: invalid conversion from 'const AtomicWord' to 'const volatile base::subtle::Atomic64_' src/malloc_hook-inl.h:87: error: initializing argument 1 of 'base::subtle::Atomic64 base::subtle::NoBarrierLoad(const volatile base::subtle::Atomic64)' src/mallochook-inl.h: In member function 'bool base::internal::HookList::empty() const [with T = void ()(const void*, size_t)]': src/malloc_hook-inl.h:124: instantiated from here ....

I see a similar issue reported against it in 2012:

https://groups.google.com/forum/#!topic/google-perftools/fCK1-T-LcO4

Martin

On 21 October 2015 at 11:59, Martin Smith mhs@google.com wrote:

OK. I'll work on this in the background. I didn't know about those mappings.

Martin

On 21 October 2015 at 11:54, Al Cutter notifications@github.com wrote:

Ah - I think need an extra entry in the make_os map in DEPS for "openbsd" (or whatever the sys.platform variable shows on OpenBSD.)

We'll likely need to add some entries in the deps_overrides too, if we're lucky (yeah...) then maybe the FreeBSD overrides will work for OpenBSD too.

— Reply to this email directly or view it on GitHub https://github.com/google/certificate-transparency/issues/986#issuecomment-149853463 .

Martin2112 commented 8 years ago

I'll keep looking at this in the background but it's low priority.