google / chartjs.dart

ARCHIVED/UNMAINTAINED Dart API for Chart.js
https://pub.dev/packages/chartjs
Other
143 stars 53 forks source link

Rename toBase64() -> toBase64Image() #11

Closed leerobinson-wf closed 7 years ago

leerobinson-wf commented 7 years ago

This function was not properly named and just returning null everytime. After switching toBase64() to toBase64Image(), I was able to confirm it worked locally.

data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAABDYAAAFmCAYAAACWZRocAAAgAElEQ…AAAgggEC/Axka8FSURQAABBBBAAAEEEEAAAQQQQCAxgf8D9AtrCHr/qMUAAAAASUVORK5CYII=

@kevmoo

googlebot commented 7 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


leerobinson-wf commented 7 years ago

@googlebot I signed it, thanks.

googlebot commented 7 years ago

CLAs look good, thanks!

kevmoo commented 7 years ago

@leerobinson-wf which version of chartjs are you using?

Need to make sure we stay aligned here...

leerobinson-wf commented 7 years ago

@kevmoo I'm using version 0.3.1.

leerobinson-wf commented 7 years ago

@kevmoo Any update on this? Thanks

kevmoo commented 7 years ago

I already had some local changes pending.

Get me a sec to get them ready....

leerobinson-wf commented 7 years ago

@kevmoo Your latest commit didn't fix the issue. The function is still called toBase64 and not toBase64Image.

kevmoo commented 7 years ago

Gah. The definitely typed thing is borked. Will reopen and pull in your fix.

Would you rebase?

Thanks!

leerobinson-wf commented 7 years ago

@kevmoo I forgot to mention you. This PR is ready again. Thanks!