Closed leerobinson-wf closed 7 years ago
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
:memo: Please visit https://cla.developers.google.com/ to sign.
Once you've signed, please reply here (e.g. I signed it!
) and we'll verify. Thanks.
@googlebot I signed it, thanks.
CLAs look good, thanks!
@leerobinson-wf which version of chartjs are you using?
Need to make sure we stay aligned here...
@kevmoo I'm using version 0.3.1.
@kevmoo Any update on this? Thanks
I already had some local changes pending.
Get me a sec to get them ready....
@kevmoo Your latest commit didn't fix the issue. The function is still called toBase64
and not toBase64Image
.
Gah. The definitely typed thing is borked. Will reopen and pull in your fix.
Would you rebase?
Thanks!
@kevmoo I forgot to mention you. This PR is ready again. Thanks!
This function was not properly named and just returning
null
everytime. After switchingtoBase64()
totoBase64Image()
, I was able to confirm it worked locally.@kevmoo