search

google / chartjs.dart

ARCHIVED/UNMAINTAINED Dart API for Chart.js
https://pub.dev/packages/chartjs
Other
143 stars 53 forks source link

Add some missing factory constructors. #29

Closed ghost closed 5 years ago

ghost commented 5 years ago

... by hand (not using "js facade gen").

For #26, but only added some of the missing, not fully covered.

kevmoo commented 5 years ago

@ntaoo – have you verified these work?

...makes me wish we had tests 😄

ghost commented 5 years ago

Yes. But only some parts of the options at my private repository, no test code there, though. If the test code base is set up. I would like to have time to add the test code for this.

On Mon, Oct 22, 2018 at 9:19 AM Kevin Moore notifications@github.com wrote:

@ntaoo https://github.com/ntaoo – have you verified these work?

...makes me wish we had tests 😄

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/google/chartjs.dart/pull/29#issuecomment-431716647, or mute the thread https://github.com/notifications/unsubscribe-auth/AAfM7bBvGfBUzetRWINfpKEDe0TN2VuXks5unQ70gaJpZM4XvhlG .

kevmoo commented 5 years ago

@ntaoo – any updates?

ghost commented 5 years ago

@kevmoo Oh, very sorry. I updated now.

supermuka commented 5 years ago

There are more constructors missing as reported in https://github.com/google/chartjs.dart/issues/22

wsv-accidis commented 5 years ago

How about merging this for now? It would be very useful.

wsv-accidis commented 5 years ago

Hey thanks @kevmoo, that was fast. Dart's awesome, keep up the good work.

oeztuerk commented 4 years ago

@ntaoo

I also had the same issue with those missing constructor as I wanted to use LinearTickOption to beginAtZero on bar charts. I fixed it by creating the missing constructor with it's attributes. See #33 . Would be grateful if you fix that on next package realease !