google / charts

https://pub.dev/packages/charts_flutter
Apache License 2.0
2.8k stars 1.2k forks source link

chart_container.dart:205:27: Warning: Operand of null-aware operation '!' has type 'SchedulerBinding' which excludes null. #735

Closed WorldpixelSoftware closed 2 years ago

WorldpixelSoftware commented 2 years ago

Hi there!

Great Package to start with!

I changed to latest master version of Flutter and there are several warnings coming up regarding charts_flutter.

chart_container.dart:205:27: Warning: Operand of null-aware operation '!' has type 'SchedulerBinding' which excludes null.
 - 'SchedulerBinding' is from 'package:flutter/src/scheduler/binding.dart'
chart_container.dart:206:24: Warning: Operand of null-aware operation '!' has type 'SchedulerBinding' which excludes null.
 - 'SchedulerBinding' is from 'package:flutter/src/scheduler/binding.dart'
chart_container.dart:209:22: Warning: Operand of null-aware operation '!' has type 'SchedulerBinding' which excludes null.
 - 'SchedulerBinding' is from 'package:flutter/src/scheduler/binding.dart'
charts_flutter-0.12.0/lib/src/chart_container.dart:232:22: Warning: Operand of null-aware operation '!' has type 'SchedulerBinding' which excludes null.
 - 'SchedulerBinding' is from 'package:flutter/src/scheduler/binding.dart'

Seems to be just a unnecessary null aware operator but the warning messages are annoying when building or rebuilding an application.

Cheers

Wissperwind commented 2 years ago

Same problem here

WorldpixelSoftware commented 2 years ago

Please accept https://github.com/google/charts/pull/739 this Pull Request or change it yourself. That should solve the error.

SpeedyTiger commented 2 years ago

well how can i solve it

igolubic commented 2 years ago

It's failing here: https://github.com/google/charts/pull/739 It would be great if somebody can fix the issue and resubmit the PR.

RonanLB commented 2 years ago

Bump, this package is owned by google and it would be nice if versions could transition nicely