search

google / charts

https://pub.dev/packages/charts_flutter
Apache License 2.0
2.81k stars 1.2k forks source link

with compile works for flutter3.0 #768

Closed joyhope closed 1 year ago

joyhope commented 2 years ago

only version update for easy to run the sample in the simulator. Otherwise the original project is unable to run now.

google-cla[bot] commented 2 years ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

For more information, open the CLA check for this pull request.

joyhope commented 2 years ago

The fixed type will make sample "selection line highlight custom shape works"

joyhope commented 2 years ago

I recommit, the sample case is working now.

joyhope commented 2 years ago

More unworkable samples are worked. It all caused a type cast problem. I changed the type define according to the error report. It just works.

crizant commented 2 years ago

Seems Google is giving up this repo, every time a new flutter version comes out, this repo lags behind for months. Do you think we should fork it and publish another version to pub.dev? No new features, just simple fixes of incompatibility with the latest flutter versions. It should relieve the pain of fellow developers.

joyhope commented 2 years ago

I agree with this idea, but I am not sure whether it is proper. I begin to add features but it seems no hope to merge in this repo. If anyone makes a start, I like to follow. I think the chart is an important library to use.

joyhope commented 2 years ago

I add chart_flutter/util/monotonex.dart , add smoth line to the chart. Screenshot from 2022-05-20 22-28-20

the chart line is smooth. but I am not sure whether this will be merged.

crizant commented 2 years ago

I add chart_flutter/util/monotonex.dart , add smoth line to the chart. Screenshot from 2022-05-20 22-28-20

the chart line is smooth. but I am not sure whether this will be merged.

Even if it got merged finally, it will be 2 months later. E.g. Flutter 2.2 null safety is released in May 2021, and the null safety fix of this library is released in July 2021.

stuartmorgan commented 1 year ago

This project is no longer maintained, and cannot accept any PRs. Community members interested in collaborating on a community-maintained fork can coordinate in this issue.