Rainymood commented 4 years ago

Summary

This PR:

Refactors the hardcoded URLs in lib/Transport.js to a convict config
Adds functionality to overwrite these urls if needed (for example if you use a reverse-proxy)

Usage

If you are behind a proxy and need to use http instead of https you can overwrite the default endpoints that Chatbase uses as follows:

var chatbase = require('@google/chatbase')
    ...
    .setCreateEndpoint('http://custom-create-endpoint.com/api/message'); // default: https://chatbase-area120.appspot.com/api/message
    .setCreateSetEndpoint('http://custom-create-set-endpoint.com/api/messages'); // default: https://chatbase-area120.appspot.com/api/messages
    .setUpdateEndpoint('http://custom-update-endpoint.com/api/messages/update'); // default: https://chatbase-area120.appspot.com/api/message/update

Why

The current URLs are hardcoded in lib/transport.js and there is no easy way of changing them in the current node package, making it difficult to use Chatbase behind a proxy which doesn't allow, for example, https connections.

googlebot commented 4 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

What to do if you already signed the CLA

Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

Rainymood commented 4 years ago

@googlebot I signed it!