search

google / ci_edit

A terminal text editor with mouse support and ctrl+Q to quit.
Apache License 2.0
223 stars 54 forks source link

support python 3.x #173

Closed hgoldfish closed 5 years ago

hgoldfish commented 6 years ago

The traceback:

goldfish@nas ~/w/ci_edit> python3 ./ci.py Traceback (most recent call last): File "./ci.py", line 32, in import app.ci_program File "/home/goldfish/workon/ci_edit/app/ci_program.py", line 36, in import app.history File "/home/goldfish/workon/ci_edit/app/history.py", line 33, in import app.prefs File "/home/goldfish/workon/ci_edit/app/prefs.py", line 201, in app.log.startup('prefs.py import time', time.time() - importStartTime) File "/home/goldfish/workon/ci_edit/app/log.py", line 141, in startup channel('startup', args) File "/home/goldfish/workon/ci_edit/app/log.py", line 69, in channel lines = parseLines(inspect.stack()[2], channel, args) File "/home/goldfish/workon/ci_edit/app/log.py", line 52, in parseLines prior = unicode(i) NameError: name 'unicode' is not defined

dschuyler commented 6 years ago

Thanks, I've started working on this, but it will take some time.

dschuyler commented 6 years ago

Progress: ci_edit can now startup with Python3. This is still very new and likely has bugs. If anyone would like to file bugs against ci_edit with Python3, feel free to do so. I don't recommend ci_edit with Python3 for serious work at this time (other than to hunt for bugs).

aaxu commented 5 years ago

Edit: Was on the wrong branch. Seems to work fine for the time being. Has it been decided if we are going to continue support for both python 2 and 3? I think default mac OS still ships with python 2.7, so it might be a good idea to until most new OS's change to 3+

dschuyler commented 5 years ago

I expect that Python 2 support will be dropped at some point. I've been running tests with both versions using tools/full_test (which also tests single and multi-threaded use).

I just pushed a change to default to Python 3.

dschuyler commented 5 years ago

I'm declaring Python 3 supported. I'm closing this enhancement. If any issues are found they will be 'bugs'.