google / ci_edit

A terminal text editor with mouse support and ctrl+Q to quit.
Apache License 2.0
223 stars 54 forks source link

Problem when using vt220 serial terminal #174

Open virtualwiz opened 6 years ago

virtualwiz commented 6 years ago

I tried to run ci_edit on an ARM development board. Since SSH is not available I used the serial connection. (this may mean that the colour support of the terminal is incomplete)

Here is the traceback 1

dschuyler commented 6 years ago

Thanks, I'll look into it.

dschuyler commented 6 years ago

I've made a change that might improve this. I haven't tested in the same environment you have, so I'm not sure whether I've fixed it. Could you give it a try and let me know what happens?

I'd also be curious to know the output of echo $TERM on the device.

virtualwiz commented 6 years ago

Many thanks for your work :)

2

It still doesn't launch in the serial terminal(whose $TERM reports 'vt220'), but I believe that this error message is a good sign. I went to buy an ethernet cable and managed to SSH to the machine. With the SSHed xterm it works perfectly.

tim 20181017091024

here is my setup

dschuyler commented 6 years ago

Thanks!

vt220 seems pretty limited. It doesn't seem to support color, or hiding the cursor or mouse input (or if it does, I haven't worked it out yet).

For now, I've made a change so that this is reported:

$ TERM=vt220 we app/actions.py

This terminal does not support color.

rather than crashing.

dschuyler commented 6 years ago

Changing this from a bug to an enhancement since the crash is fixed. The enhancement is to support vt220 more (to whatever reasonable extent 'more' is, that's TBD). The first step would be to determine if vt220 can support ctrl-q and mouse input.