search

google / ci_edit

A terminal text editor with mouse support and ctrl+Q to quit.
Apache License 2.0
223 stars 54 forks source link

Implement jump to opposite bracket feature #181

Closed sauravchirania closed 5 years ago

sauravchirania commented 5 years ago

Do we have a better choice than CTRL_B key? Is there a rule to arrange methods inside a class? I have created two new methods just below init() in Actions class. Should I move them somewhere lower in the file?

dschuyler commented 5 years ago

Sorry for the delay. I was out on vacation.

We're pretty limited on key combinations in the terminal. I'd prefer something like ctrl+m for matching. Unfortunately ctrl+m can be tricky because it may be mapped to ctrl+j.

Order of methods: I generally try to keep the methods in alphabetical order. Though I haven't always stuck to this, so it's a weak rule.

sauravchirania commented 5 years ago

Thank you for the code review :-)

We're pretty limited on key combinations in the terminal. I'd prefer something like ctrl+m for matching. Unfortunately ctrl+m can be tricky because it may be mapped to ctrl+j.

Yes, ctrl+m looks like a better idea. I'll see if I can figure out a way to map this feature to ctrl+m.

dschuyler commented 5 years ago

We can also land this CL without specifying ctrl+b for matching. E.g. comment out that CTRL_B line in cu_editor.py.