google / ci_edit

A terminal text editor with mouse support and ctrl+Q to quit.
Apache License 2.0
223 stars 54 forks source link

Case insensitive Find #29

Open aaxu opened 7 years ago

aaxu commented 7 years ago

Should we make it a default that when you search for a string in the text editor, it's automatically case insensitive?

dschuyler commented 7 years ago

Each time I start down the path of improving Find, I keep coming up with different wild ideas for how find (and replace; oh and find/replace in files) should be presented.

Yes, a case-insensitive Find should be available -- so should a case-sensitive find. What is a good way to allow the user to control their choice?

Also: How should the current search settings be presented to the user? I'd like something on-screen while the users is in InteractiveFind that shows whether case sensitivity, regex, whole word, and other options are enabled.

wdyt?

aaxu commented 7 years ago

Yeah I think it's too much of a hassle to have another shortcut or a whole menu for it. We can add a few buttons in the InteractiveFind window that represent the options. We'd be pressed for space, so maybe we could have a simple icon and I don't know if it's possible, but it'd also be nice if there would be help text if the user hovers over the button. I think that would be the cleanest way to go about this. I'm kind of basing my interpretations on Sublime Text cause I use that editor a lot. They support regex search, searching inside a selection, and some other features which I think are cool and maybe we can do in the future.

dschuyler commented 7 years ago

fyi, I made some updates to the outline of find design ideas I've been kicking around (in design/find).

aaxu commented 7 years ago

Oh yeah, I said it before, but I think something like sublime text would be convenient. Pressed buttons in the find window to show that certain features are on and possibly some help text or labels to appear when the user hovers over a button with the mouse, just so we can save room, though I still don't know if it's still possible yet.