citycrc.h not installed by `make install`

google / cityhash

Automatically exported from code.google.com/p/cityhash

MIT License

1.1k stars 183 forks source link

citycrc.h not installed by `make install` #22

Closed somersf closed 7 years ago

somersf commented 7 years ago

The README for CityHash describes CityHashCrc128() and CityHashCrc256(), suggesting they are part of the published API.

However, they are only declared in citycrc.h, which is not installed by make install (it only installs the city.h header). As a result, the *Crc* functions aren't cleanly available to package-based installations of CityHash.

Please include citycrc.h in the installed files list.

Added: tested on macOS. It seems it is installed on Linux...

somersf commented 7 years ago

Apologies - I found the problem. I had to add --enable-sse4.2.

I had brew install cityhashed it. I had to:

brew uninstall cityhash
brew edit cityhash to add the extra option to the system "./configure" ... line
brew install --build-from-source cityhash