google / clasp

🔗 Command Line Apps Script Projects

https://developers.google.com/apps-script/guides/clasp

Apache License 2.0

4.54k stars 424 forks source link

Pushing V8 code into non-V8 project #765

Open bjohas opened 4 years ago

bjohas commented 4 years ago

When pushing V8 code into non-V8 project, the push fails. Howeer, the error message "Error: Syntax error: Missing ; before statement. ", while obviously true, didn't immediately make me realise that this is with V8/non-V8 code.

Expected Behavior

A warning message would be helpful, but may not be possible.

Specifications

2.3.0

oshliaer commented 4 years ago

Could you wait #778 merging then return to this again?

PopGoesTheWza commented 4 years ago

@bjohas are you pushing plain .js or .ts?

If its .js then catching the error would be nice to have.

bjohas commented 4 years ago

Plain .js, i.e., trying to push "V8-plain-js" into a non-V8 project. I'll look out for the PR merge and then try again.

PopGoesTheWza commented 4 years ago

778 have a cleaner error handling architecture but there is probably not yet a user friendly catch for this case

bjohas commented 4 years ago

OK, sure - I'll test again once https://github.com/google/clasp/pull/778 has been merged.

bjohas commented 4 years ago

Thanks for working on clasp!

PopGoesTheWza commented 4 years ago

Can you test with the #791 unofficial release?

npm uninstall -g @google/clasp && npm install -g forked-clasp
clasp --version
# should be 2.4.0 or more

bjohas commented 4 years ago

Thank you - will do and report back!

PopGoesTheWza commented 3 years ago

@bjohas what is the status for this issue?

PopGoesTheWza commented 3 years ago

Should be fixed in https://github.com/google/clasp/releases/tag/v2.3.1

bjohas commented 3 years ago

Thank you so much - I'm sorry I didn't get round to testing it, as the old code had gone away. I'd be happy for this to be closed. If I come across the error again, I can always come back to this?