Change the turtle to be drawn so that the current position is at its …

google / clojure-turtle

A Clojure library that implements the Logo programming language in a Clojure context

Apache License 2.0

426 stars 41 forks source link

Change the turtle to be drawn so that the current position is at its … #30

Closed hairybreeches closed 7 years ago

hairybreeches commented 7 years ago

…centroid rather than its base

I chose to move the pen back by the required amount (using penup and pendown) since this seemed easier to read/understand than the moderately involved mathematics it would take to adjust the "teleport" position.

This commit fixes issue #27

My first pull request on a Git repository - forgive me if I've done something heinous.

googlebot commented 7 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
If you signed the CLA as a corporation, please let us know the company's name.

hairybreeches commented 7 years ago

I totally just signed that CLA.

googlebot commented 7 years ago

CLAs look good, thanks!

echeran commented 7 years ago

Looks good, and so is your approach. I hope the googlebot was polite and well-behaved towards you.

Since it's your first git repo pull request, thanks for the submission! I'll go ahead amend the commit msg to be a typical length (< 200-ish chars). I'm just using git commit --amend for that.

And I modified the msg slightly once more, if that's okay. The centroid has a particular meaning, and for triangles, is found at the intersection of the angle bisectors. So I changed "centroid" to "inside".