search

google / closure-compiler-npm

Package for managing and documenting closure-compiler for use via npm
Apache License 2.0
333 stars 66 forks source link

Does google/closure-compiler need to depend on google/closure-compiler-npm ? #302

Closed brad4d closed 6 months ago

brad4d commented 8 months ago

There's currently a dependency from closure-compiler to closure-compiler-npm defined here.

https://github.com/google/closure-compiler/blob/564c23785c6e9f83a1dcf4f6c6bf41bc4301cc49/package.json#L11

@ChadKillingsworth what is this dependency for? Is it actually needed?

ChadKillingsworth commented 8 months ago

It was done to ensure that the compiler wasn't breaking the npm integration. It basically runs the tests from the npm project in the main repo. https://github.com/google/closure-compiler/blob/564c23785c6e9f83a1dcf4f6c6bf41bc4301cc49/.github/workflows/ci.yaml#L93