Closed mikesamuel closed 8 years ago
The compiler runs without an exception when I address the first warning by replacing
/**
* ...
* @param {!Array.<*>} values an array of n parts to interpolate between
* the end of the corresponding raw part and the start of its follower.
*/
function make(ctor, flags, template, ...values) {
with
/**
* ...
* @param {...*} values an array of n parts to interpolate between
* the end of the corresponding raw part and the start of its follower.
*/
function make(ctor, flags, template, ...values) {
Here's a minimal case that repros the problem.
/**
* @param {!Array.<*>} x
*/
function foo(...x) {
var { y } = x;
}
compiled using the latest version of the compiler via
$ java -jar tools/compiler.jar --language_in=ECMASCRIPT6 \
--warning_level=VERBOSE --jscomp_error="*" \
--compilation_level=ADVANCED --js min-repro-case.js
on
$ java -version
java version "1.8.0_45"
Java(TM) SE Runtime Environment (build 1.8.0_45-b14)
Java HotSpot(TM) 64-Bit Server VM (build 25.45-b02, mixed mode)
Your repo case is missing the --language_out=ECMASCRIPT5
flag - but I confirmed the exception even with transpilation.
I think I forgot the magic word "fixed" but that commit should have fixed this.
I get an internal error report running the compiler against RegExp.make.js/issue11.
To reproduce
git clone -b issue11 git@github.com:mikesamuel/regexp-make-js.git regexp-make-js-issue11
java -jar tools/compiler.jar --language_in=ECMASCRIPT6 --warning_level=VERBOSE --jscomp_error="*" --compilation_level=ADVANCED --js RegExp.make.js --externs externs.js
I see the below.