search

google / closure-compiler

A JavaScript checker and optimizer.
https://developers.google.com/closure/compiler/
Apache License 2.0
7.37k stars 1.15k forks source link

Better wording on FAQ page #1586

Open Dominator008 opened 8 years ago

Dominator008 commented 8 years ago

https://developers.google.com/closure/compiler/faq The sentence

Remember that Closure Compiler and other minifiers might have expectations about the incoming code.

reads better if changed to:

Remember that Closure Compiler and other minifiers might have different expectations about the incoming code.

MatrixFrog commented 8 years ago

I'm skeptical of that whole answer, to be honest. Sure you could minify first with Closure and then with something else, or vice versa, but I wouldn't generally expect to get good results. I wonder who is doing this and why.

Dominator008 commented 8 years ago

@MatrixFrog I'm skeptical too, but large projects might include already minified third-party JavaScript libraries in the build process, and SIMPLE_OPTIMIZATIONS can usually accept those.

On the other hand, some projects include the source of third-party JavaScript libraries such as the entire Closure Library. Eg: https://github.com/SeleniumHQ/selenium/tree/master/third_party/closure/goog

concavelenz commented 8 years ago

I've never seen that question, so it doesn't seem like an FAQ. Just remove it.