search

google / closure-compiler

A JavaScript checker and optimizer.
https://developers.google.com/closure/compiler/
Apache License 2.0
7.31k stars 1.15k forks source link

Include LICENSE.txt in the released jar files #4147

Closed brad4d closed 4 months ago

brad4d commented 5 months ago

I've created this as a pull request instead of a normal Google-internal change because it was easier to work on the OSS build rules from a git repository.

niloc132 commented 5 months ago

I think the title might have a typo - if it is "unshaded", then it should not include dependencies, by including dependencies, the jar then would be shaded.

Of course there is also the distinction between "the shaded classes are rebased/repackaged" and just merging all of the jars, but it would hurt our use cases if the "unshaded" jars must then contain dependencies instead of relying on dependency management tools to look them up as needed.

brad4d commented 5 months ago

I've just pushed a new version of this fix that I think is more satisfactory.

brad4d commented 4 months ago

@gkdn fixed the underlying problem that this hacky PR was trying to fix, so it is no longer necessary.