Specify type of digits in Number.toFixed

google / closure-compiler

A JavaScript checker and optimizer.

https://developers.google.com/closure/compiler/

Apache License 2.0

7.31k stars 1.15k forks source link

Specify type of digits in Number.toFixed #4153

Closed zbynek closed 4 months ago

zbynek commented 4 months ago

According to the docs this argument has to be a number. Using the more specific type is needed for https://github.com/google/elemental2/issues/129

zbynek commented 4 months ago

@h-joo thanks for merging my other PR, will you be able to check/merge this one too?

h-joo commented 4 months ago

@h-joo thanks for merging my other PR, will you be able to check/merge this one too?

First I want thank you for your contribution! I actually am happy with the current state of the PR, but this change broke some internal projects so I'm fixing them up before I can merge this in.