google / closure-compiler

A JavaScript checker and optimizer.
https://developers.google.com/closure/compiler/
Apache License 2.0
7.41k stars 1.15k forks source link

closure-compiler-unshaded v20240317 embeds jakarta.annotation-api #4161

Open tmortagne opened 8 months ago

tmortagne commented 8 months ago

It can cause some conflicts when you depend on both closure-compiler-unshaded and jakarta.annotation-api directly or through other dependencies.

I would have expected it to be a dependency, along with the others declared in the pom file.

brad4d commented 8 months ago

Thanks for pointing this out. We're unlikely to do anything about it immediately, but I expect we will fix it before doing another release.

tmortagne commented 8 months ago

Thanks @brad4d, that's definitely good enough for me 🙂

gkdn commented 8 months ago

@tmortagne Do you know if this has regressed in the latest release?

niloc132 commented 8 months ago

Yes, it appears this is a regression in the latest release:

tmortagne commented 8 months ago

Yes, as detailed by @niloc132 and as I should have mentioned a bit more explicitly in the issue description, it's indeed a regression from v20231112.