search

google / closure-library

Google's common JavaScript library
code.google.com/closure/library/
Apache License 2.0
4.89k stars 1.05k forks source link

Parse error in goog.ui.PopupMenu #453

Closed koto closed 9 years ago

koto commented 9 years ago

There is a merge conflict here:

https://github.com/google/closure-library/blob/master/closure/goog/ui/popupmenu.js#L330

Do you plan to have a CI? It's possible for Travis to catch those bugs by e.g. compiling the library. Take a look at our configuration: https://github.com/google/end-to-end/blob/master/.travis.yml

teppeis commented 9 years ago

@koto this repo already has CI and the conflict was caught: https://travis-ci.org/google/closure-library/builds/59411093, but ignored...

nanaze commented 9 years ago

fixed