Closed moberghammer closed 8 years ago
I signed it!
2016-05-17 9:59 GMT+02:00 googlebot notifications@github.com:
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
[image: :memo:] Please visit https://cla.developers.google.com/ https://cla.developers.google.com/ to sign.
Once you've signed, please reply here (e.g. I signed it!) and we'll
verify. Thanks.
- If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data https://cla.developers.google.com/clas and verify that your email is set on your git commits https://help.github.com/articles/setting-your-email-in-git/.
- If you signed the CLA as a corporation, please let us know the company's name.
— You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub https://github.com/google/closure-linter/pull/99#issuecomment-219646309
CLAs look good, thanks!
Hi, thanks for your contribution.
Please make sure that: • all occurrences of 'return' are fixed • all tests pass • there is a testcase for the @returns case • all changed code still adheres to the Google Python Styleguide: https://google.github.io/styleguide/pyguide.html
Currently python closure_linter/full_test.py run on google/closure-linter results in:
FAIL: runTest (closure_linter.common.filetestcase.AnnotatedFileTestCase)
Traceback (most recent call last): File "build/bdist.linux-x86_64/egg/closure_linter/common/filetestcase.py", line 80, in runTest self.assertEqual(expected, got) AssertionError: Lists differ: [(20, 1), (20, 1), (21, 2), (2... != [(20, 1), (20, 1), (21, 2), (2...
First differing element 7: (32, 200) (31, 200)
Second list contains 2 additional elements. First extra element 96: (1324, 220)
Diff is 1497 characters long. Set self.maxDiff to None to see it.
Ran 43 tests in 1.392s
FAILED (failures=1)
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
:memo: Please visit https://cla.developers.google.com/ to sign.
Once you've signed, please reply here (e.g.
I signed it!
) and we'll verify. Thanks.