Closed giovannt0 closed 4 years ago
Merging #257 into master will increase coverage by
2.62%
. The diff coverage is70.73%
.
@@ Coverage Diff @@
## master #257 +/- ##
==========================================
+ Coverage 65.39% 68.02% +2.62%
==========================================
Files 14 29 +15
Lines 968 1992 +1024
==========================================
+ Hits 633 1355 +722
- Misses 335 637 +302
Flag | Coverage Δ | |
---|---|---|
#nosetests | 68.02% <70.73%> (+2.62%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
Impacted Files | Coverage Δ | |
---|---|---|
...cloudforensics/providers/azure/internal/network.py | 25.00% <25.00%> (ø) |
|
libcloudforensics/providers/aws/internal/kms.py | 40.00% <40.00%> (ø) |
|
libcloudforensics/providers/gcp/forensics.py | 54.54% <48.00%> (-10.46%) |
:arrow_down: |
libcloudforensics/providers/aws/forensics.py | 56.16% <53.06%> (-13.61%) |
:arrow_down: |
...ibcloudforensics/providers/gcp/internal/compute.py | 56.08% <54.28%> (-6.27%) |
:arrow_down: |
...cs/providers/gcp/internal/compute_base_resource.py | 37.33% <54.28%> (+0.82%) |
:arrow_up: |
libcloudforensics/providers/aws/internal/log.py | 73.07% <55.55%> (-4.20%) |
:arrow_down: |
...bcloudforensics/providers/gcp/internal/function.py | 40.54% <62.50%> (+8.28%) |
:arrow_up: |
...loudforensics/providers/azure/internal/resource.py | 65.38% <65.38%> (ø) |
|
...ibcloudforensics/providers/gcp/internal/project.py | 61.90% <66.66%> (-3.81%) |
:arrow_down: |
... and 35 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 5164527...6c1d413. Read the comment docs.
The new pylint package (https://github.com/PyCQA/pylint/releases/tag/pylint-2.6.0) adds a few more rules (in particular compliance with https://legacy.python.org/dev/peps/pep-3134/) that fail on our current codebase.
This PR fixes two rules:
super()
without arguments in Py3 (migrating fromsuper(Class, self).__init__()
tosuper().__init__()
raise from
form so that Python outputs a clearer error message (The above exception was the direct cause of the following exception:
instead of the currentDuring handling of the above exception, another exception occurred:
)This should additionally fix current open and failing PRs (#255)
Signed-off-by: Theo Giovanna gtheo@google.com