Closed aarontp closed 3 years ago
Merging #271 (2f8ba28) into master (e4448c6) will increase coverage by
2.35%
. The diff coverage is70.27%
.
@@ Coverage Diff @@
## master #271 +/- ##
==========================================
+ Coverage 65.39% 67.74% +2.35%
==========================================
Files 14 29 +15
Lines 968 2037 +1069
==========================================
+ Hits 633 1380 +747
- Misses 335 657 +322
Flag | Coverage Δ | |
---|---|---|
nosetests | 67.74% <70.27%> (+2.35%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
Impacted Files | Coverage Δ | |
---|---|---|
...cloudforensics/providers/azure/internal/network.py | 24.52% <24.52%> (ø) |
|
libcloudforensics/providers/aws/internal/kms.py | 40.00% <40.00%> (ø) |
|
libcloudforensics/providers/gcp/forensics.py | 54.54% <48.00%> (-10.46%) |
:arrow_down: |
libcloudforensics/providers/aws/forensics.py | 56.16% <53.06%> (-13.61%) |
:arrow_down: |
...cs/providers/gcp/internal/compute_base_resource.py | 37.33% <54.28%> (+0.82%) |
:arrow_up: |
libcloudforensics/providers/aws/internal/log.py | 73.07% <55.55%> (-4.20%) |
:arrow_down: |
...ibcloudforensics/providers/gcp/internal/compute.py | 56.68% <55.81%> (-5.67%) |
:arrow_down: |
...bcloudforensics/providers/gcp/internal/function.py | 40.54% <62.50%> (+8.28%) |
:arrow_up: |
...loudforensics/providers/azure/internal/resource.py | 65.38% <65.38%> (ø) |
|
...ibcloudforensics/providers/gcp/internal/project.py | 61.90% <66.66%> (-3.81%) |
:arrow_down: |
... and 35 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update efc65b5...2f8ba28. Read the comment docs.
LGTM
Getting below build error but that's not due to this (small) code change. "error: PyJWT 2.0.0a1 is installed but PyJWT[crypto]<2,>=1.0.0 is required by {'msal'}"
Thanks for looking into the reason the tests are failing @hacktobeer. I'll merge these changes and do a dep bump
This is so that we can have a predictable device name in the instance (which is needed by Turbinia).