Closed tomchop closed 3 years ago
:exclamation: No coverage uploaded for pull request base (
main@223558b
). Click here to learn what that means. The diff coverage isn/a
.
@@ Coverage Diff @@
## main #342 +/- ##
=======================================
Coverage ? 64.20%
=======================================
Files ? 33
Lines ? 2422
Branches ? 0
=======================================
Hits ? 1555
Misses ? 867
Partials ? 0
Flag | Coverage Δ | |
---|---|---|
nosetests | 64.20% <0.00%> (?) |
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 223558b...f4c0b0c. Read the comment docs.
One could argue that it makes it easier to debug to have an intermediary variable, but I agree that we can remove it altogether.
Yeah, I don't have a strong preference here, so I'll approve this and let you decide
(Pending build success)
Force merging this as we want these changes in sooner rather than later.
Calls to
GoogleCloudFunction
would otherwise retain stale credentials if the object was reused to callExecuteFunction
over long periods of time