Closed ramo-j closed 3 years ago
Mmmh. Why did you delete all the work I just did in https://github.com/google/cloud-forensics-utils/pull/314? :D
We want to test the CLI. Since the CLI calls the underlying forensics
package, testing this covers more ground than the current e2e.py
file. So, for your S3 tests, what you should add is a test in e2e_cli.py
that goes through the CLI as the other tests in that file. Once that works, we will deprecate e2e.py
and only add new e2e tests that go through the CLI. Let me know if this is unclear, happy to chat further.
Closing, will discuss OOB.
Per #349, #350:
Confirmed the tests work locally:
Closes #349