search

google / cloud-forensics-utils

Python library to carry out DFIR analysis on the Cloud
Apache License 2.0
453 stars 89 forks source link

Revert 358, add wait for copy instance launch #359

Closed ramo-j closed 3 years ago

ramo-j commented 3 years ago

Previous PR did not fix E2E failure in jenkins - On small snapshots the instance finishes the copy and terminates before the health checks pass, causing the health check wait to time out.

Revert that PR, and add a wait time for instance launch.

codecov-commenter commented 3 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@1b7b07c). Click here to learn what that means. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #359   +/-   ##
=======================================
  Coverage        ?   58.88%           
=======================================
  Files           ?       34           
  Lines           ?     2797           
  Branches        ?        0           
=======================================
  Hits            ?     1647           
  Misses          ?     1150           
  Partials        ?        0
Flag Coverage Δ
nosetests 58.88% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1b7b07c...2255722. Read the comment docs.