search

google / cloud-forensics-utils

Python library to carry out DFIR analysis on the Cloud
Apache License 2.0
453 stars 89 forks source link

GCP effective firewall listing #361

Closed jonathan-greig closed 3 years ago

jonathan-greig commented 3 years ago

Relates to #339

codecov-commenter commented 3 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@745a23d). Click here to learn what that means. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #361   +/-   ##
=======================================
  Coverage        ?   59.44%           
=======================================
  Files           ?       34           
  Lines           ?     2838           
  Branches        ?        0           
=======================================
  Hits            ?     1687           
  Misses          ?     1151           
  Partials        ?        0
Flag Coverage Δ
nosetests 59.44% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 745a23d...de2acd0. Read the comment docs.

jonathan-greig commented 3 years ago

Addressed code review comments and also did some further normalisation of the fw rules as there were inconsistencies in FW vs FW policy field names IPProtocol vs ipProtocol