Closed jonathan-greig closed 3 years ago
:exclamation: No coverage uploaded for pull request base (
main@745a23d
). Click here to learn what that means. The diff coverage isn/a
.
@@ Coverage Diff @@
## main #361 +/- ##
=======================================
Coverage ? 59.44%
=======================================
Files ? 34
Lines ? 2838
Branches ? 0
=======================================
Hits ? 1687
Misses ? 1151
Partials ? 0
Flag | Coverage Δ | |
---|---|---|
nosetests | 59.44% <0.00%> (?) |
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 745a23d...de2acd0. Read the comment docs.
Addressed code review comments and also did some further normalisation of the fw rules as there were inconsistencies in FW vs FW policy field names IPProtocol
vs ipProtocol
Relates to #339