search

google / cloud-forensics-utils

Python library to carry out DFIR analysis on the Cloud
Apache License 2.0
453 stars 89 forks source link

STS and S3ToGCS #364

Closed Fryyyyy closed 2 years ago

Fryyyyy commented 2 years ago

A cherry pick of the functions from PR#312 that @ramo-j needs, incorporating the comments and review from that CL

codecov-commenter commented 2 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@71b33ea). Click here to learn what that means. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #364   +/-   ##
=======================================
  Coverage        ?   59.43%           
=======================================
  Files           ?       36           
  Lines           ?     2946           
  Branches        ?        0           
=======================================
  Hits            ?     1751           
  Misses          ?     1195           
  Partials        ?        0
Flag Coverage Δ
nosetests 59.43% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 71b33ea...a4f4295. Read the comment docs.

ramo-j commented 2 years ago

As you mentioned, I'm keen on using this functionality. When we're ready to merge, can you update the version in libcloudforensics/__init__.py so I can tag a new release once this is merged? Saves another PR just for that.

giovannt0 commented 2 years ago

As you mentioned, I'm keen on using this functionality. When we're ready to merge, can you update the version in libcloudforensics/__init__.py so I can tag a new release once this is merged? Saves another PR just for that.

A new PR for the release would be preferable, saves us time when we have to check which commit was last included in the release.