google / cloud-forensics-utils

Python library to carry out DFIR analysis on the Cloud

Apache License 2.0

452 stars 89 forks source link

[azure] add image_reference option, fix multi-subscriptions bug, docs #422

Closed juju4 closed 5 months ago

juju4 commented 2 years ago

adding image_reference option: this allows to use a different sku than default one (bionic) and also to use a shared gallery image with any custom image
fix multi-subscription bug: previous state was checking existing of resource_group_name in src_profile which works fine if src and dst subscriptions are the same but not if different
docs: more details especially on app token creation, azure permissions, and image_reference

codecov-commenter commented 2 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@719093b). Click here to learn what that means. The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #422   +/-   ##
=======================================
  Coverage        ?   59.13%           
=======================================
  Files           ?       49           
  Lines           ?     4038           
  Branches        ?        0           
=======================================
  Hits            ?     2388           
  Misses          ?     1650           
  Partials        ?        0

Flag	Coverage Δ
nosetests	`59.13% <0.00%> (?)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 719093b...e159b57. Read the comment docs.

giovannt0 commented 2 years ago

Thank you for your contribution! Please have a look at https://cla.developers.google.com/

juju4 commented 2 years ago

Changes done. I'm fine with CLA but I won't change github settings for it. If it helps, consider contribution as public domain and merged separately.

juju4 commented 1 year ago

any status/blocker on this PR? change requested seems to be done

ramo-j commented 1 year ago

Hi @juju4

I don't think we can merge this without the CLA.

If it helps, consider contribution as public domain and merged separately.

I'm no lawyer, but I don't think this would help, as it won't change the authorship of the code - you would still be the author, even if one of us made an identical PR with our name on it.

tomchop commented 1 year ago

@juju4 , I don't think accepting the CLA requires you to change any GitHub settings; all you need to do is go through the instructions here https://cla.developers.google.com/ and click through the prompts.

juju4 commented 1 year ago

Tried again for CLA but my reading is still that this require a change to github associated email(s)

"Your contribution (commit) must be associated with at least one of: The primary email on your Google Account associated with the signed CLA. An Alternate email on your Google Account associated with the signed CLA. See and modify your aternate emails at https://myaccount.google.com/alternateemail. The GitHub username associated with the signed CLA."

Only github username not matched to a google account (third case) does not seem to allow to sign it. Always redirected to accounts.google.com