search

google / cloud-forensics-utils

Python library to carry out DFIR analysis on the Cloud
Apache License 2.0
452 stars 89 forks source link

Updated snapshot behaviour for when the resource exists already #431

Closed ramo-j closed 2 years ago

ramo-j commented 2 years ago

Currently implementation is that when attempting to snapshot a disk in GCE, if the snapshot exists already, an error is thrown. This PR captures that and returns the existing snapshot in such an event. The creation is also tracked, so the snapshot is only deleted if the snapshot was created anew.

Also, unrelated updates for Azure tests.

codecov-commenter commented 2 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@4e396e9). Click here to learn what that means. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #431   +/-   ##
=======================================
  Coverage        ?   59.10%           
=======================================
  Files           ?       49           
  Lines           ?     4018           
  Branches        ?        0           
=======================================
  Hits            ?     2375           
  Misses          ?     1643           
  Partials        ?        0
Flag Coverage Δ
nosetests 59.10% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4e396e9...21204a4. Read the comment docs.