google / cloud-forensics-utils

Python library to carry out DFIR analysis on the Cloud
Apache License 2.0
452 stars 89 forks source link

Added in retry on CreateDiskFromSnapshot when snapshot isn't yet ready #433

Closed ramo-j closed 2 years ago

ramo-j commented 2 years ago

Pretty much what it says on the tin - When the snapshot being used to create a disk isn't ready yet, wait for the snapshot to become ready.

codecov-commenter commented 2 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@985c723). Click here to learn what that means. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #433   +/-   ##
=======================================
  Coverage        ?   59.14%           
=======================================
  Files           ?       49           
  Lines           ?     4026           
  Branches        ?        0           
=======================================
  Hits            ?     2381           
  Misses          ?     1645           
  Partials        ?        0           
Flag Coverage Δ
nosetests 59.14% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 985c723...0a36439. Read the comment docs.

ramo-j commented 2 years ago

As per OOB discussion - Closing this out for another tactic.