search

google / cloud-forensics-utils

Python library to carry out DFIR analysis on the Cloud
Apache License 2.0
459 stars 88 forks source link

Compute resources names are treated as project-wide unique identifiers #440

Closed jonathan-greig closed 2 years ago

jonathan-greig commented 2 years ago

Fixes #439

Changes libcloudforensics.providers.gcp.internal.ListInstances to return a dictionary keyed on instance ID instead of instance name which isn't unique project wide (#439).

codecov-commenter commented 2 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@719093b). Click here to learn what that means. The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #440   +/-   ##
=======================================
  Coverage        ?   59.17%           
=======================================
  Files           ?       49           
  Lines           ?     4051           
  Branches        ?        0           
=======================================
  Hits            ?     2397           
  Misses          ?     1654           
  Partials        ?        0
Flag Coverage Δ
nosetests 59.17% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 719093b...d6dd3a1. Read the comment docs.