search

google / cloud-forensics-utils

Python library to carry out DFIR analysis on the Cloud
Apache License 2.0
459 stars 88 forks source link

Bugfix: truncate name before regex validation #447

Closed tomchop closed 2 years ago

tomchop commented 2 years ago

The regex would never be valid if the name was too long. Conversely, the truncate statement would never have any effect, as only short-enough names would get truncated.

tomchop commented 2 years ago

Failing tests seem to be related to Azure, and not this change.

codecov-commenter commented 2 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@c95fd80). Click here to learn what that means. The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #447   +/-   ##
=======================================
  Coverage        ?   59.14%           
=======================================
  Files           ?       49           
  Lines           ?     4031           
  Branches        ?        0           
=======================================
  Hits            ?     2384           
  Misses          ?     1647           
  Partials        ?        0
Flag Coverage Δ
nosetests 59.14% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c95fd80...19085a9. Read the comment docs.